throw exceptions in OwnerMail2GID
#352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ownerMail2GID() method to throw exceptions instead of returning the input unchanged when an email lookup fails. The change improves error handling by making it explicit when an email cannot be found in LDAP.
- Modified
ownerMail2GID()andgetUidFromEmail()to throwEntryNotFoundExceptionwhen email lookup fails - Added try-catch blocks in calling code to maintain backward-compatible behavior
- Added test coverage for invalid PI email scenarios
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/lib/exceptions/EntryNotFoundException.php | New exception class for entry lookup failures |
| resources/lib/UnityLDAP.php | Updated getUidFromEmail() to throw exception with added type hints and documentation |
| resources/lib/UnityGroup.php | Updated ownerMail2GID() to throw exception instead of returning input unchanged |
| webroot/panel/new_account.php | Added exception handling for email-to-GID conversion with fallback to existing validation |
| webroot/panel/groups.php | Added exception handling for email-to-GID conversion with fallback to existing validation |
| resources/autoload.php | Added autoload entry for new exception class |
| test/phpunit-bootstrap.php | Added test bootstrap entry for new exception class |
| test/functional/PIMemberRequestTest.php | Added test case for invalid PI email handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Open
bryank-cs
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OwnerMail2GIDdoesn't always return a GID. If no such owner mail is found, it returns the owner mail. This is confusing.getUidFromEmaildoesn't always return anLDAPEntry. If no such email is found, it returns no value. This makes my editor complain that "not all code paths return a value".Also added a test to confirm that the error message is added to
MODAL_ERRORS.